Add SCPI command to add COEFFICIENT comment(s)

jankae / LibreCAL

4 port eCal module

GNU General Public License v3.0

60 stars 19 forks source link

Add SCPI command to add COEFFICIENT comment(s) #10

Closed bvernoux closed 1 year ago

bvernoux commented 1 year ago

It will be great to add SCPI command to add COEFFICIENT header comments especially to provide details of VNA and setup used ... The SCPI command could be named :COEFF:ADD_COMMENT with parameter containing a string for the comment up to 120 chars maximum for example

bvernoux commented 1 year ago

@jankae Are you ok for that proposal ? as I plan to implement it (and do a PR after)

jankae commented 1 year ago

Sure, if you think this is a useful addition go ahead and implement it. How to you plan to store the comment on the device?

bvernoux commented 1 year ago

I have implemented and tested with success the :COEFF:ADD_COMMENT All has been added in https://github.com/jankae/LibreCAL/pull/13

bvernoux commented 1 year ago

Feature merged issue closed