jankae / LibreVNA

100kHz to 6GHz 2 port USB based VNA
GNU General Public License v3.0
1.08k stars 204 forks source link

Mistake in calculation of quality factor #213

Closed AlaiziyZukerman closed 1 year ago

AlaiziyZukerman commented 1 year ago

LibreVNA Version

os Windows, last release

Steps to reproduce

Expected behavior

quality factor = | reactance / resistance |

Extra information & Setup and Calibration files

jankae commented 1 year ago

Looks like you are correct, I was using Q = |imag(S11) / real(S11)| instead. This gives the same result in some edge cases but is wrong for most values. I have fixes this now, thank you for reporting the problem.

Please, add |Z| (complex resistance module) numeric and graphical in GUI.

I don't understand this part. What exactly do you mean by |Z|? The magnitude of the complex impedance?

AlaiziyZukerman commented 1 year ago

yes, I mean magnitude of the complex impedance. measure it in Ohm like resistance or reactance.

jankae commented 1 year ago

Did you see these options? image I think they should cover that (unless I am still not understanding what you mean)

AlaiziyZukerman commented 1 year ago

image reactance and resistance is a usable options, but I need |Z| like on image.

jankae commented 1 year ago

There is no option to plot the magnitude of the impedance on a graph. I didn't really think anyone would need that, since it loses the vector information. These are your options right now: