search

jankapunkt / latexcv

:necktie: A collection of cv and resume templates written in LaTeX. Leave an issue if your language is not supported!
MIT License
2.89k stars 603 forks source link

Use config files to configure personal info and cv events #21

Closed jankapunkt closed 4 years ago

jankapunkt commented 5 years ago

In the long run it makes more sense to define these info in a config file. Every template (except infographics) includes them using \input and retrieves them via \meta<name> and \eventsLoad or \eventsRender.

The render of a \cvevent is still part of each template. The whole change should be backward compatible.

jankapunkt commented 5 years ago

@watchers Anyone wants to review or comment on this?

CsatiZoltan commented 5 years ago

I will soon dig into the details of the source codes and give my opinion.

CsatiZoltan commented 5 years ago

Using global config files makes the content separated from the style, except when special templates (such as infographics, or the upcoming academic) are used. Apart from this, do you think the end-user can edit the CSV file more easily than the original tex file? I think - if sticking to the original concept of being self-contained and easy-to-understand - the current version in the master branch is easier to comprehend. What if the user breaks the CSV file? Then I guess he/she receives a rather cryptic error message from the datatool Latex package. In my opinion, the idea of using config files is fine, but not for substantially different template files. Or you could leave it for the "industrial" CVs, but then filling in the personal data will be different for the classic, modern, etc. templates and for the infographics template.

jankapunkt commented 5 years ago

Thank you @CsatiZoltan makes sense and that was also the reason why I first opened this as PR for review instead of directly merging into master. Let's keep it open for further discussion for now. I will not merge it soon. Maybe it can remain as an additional branch for those who prefer this method?

CsatiZoltan commented 5 years ago

Yes, I would definitely keep it. You could set a pointer to this branch in the README of the master branch.