search

jankatins / knitpy

knitpy: Elegant, flexible and fast dynamic report generation with python
https://github.com/jankatins/knitpy
Other
368 stars 29 forks source link

Fix gh19 #24

Closed thatcher closed 3 years ago

thatcher commented 9 years ago

Hey Jan, sorry for my absence, had a big release at work I had to focus on for a few weeks.

I've figured out my workflow and am resubmitting this pull request. I did add the file name as input in the error message as well as the resolved filename.

I didnt add a unit test just because the current unit tests framework is built around comparing rendered output. If you frame how you want to test command line or general api method in/out I'll add a unit test but i didnt want to try to guess at a broad strategy.

Cheers, my report engineer is enjoying working with knitpy and the other engineers will be able to contribute much more easily than before.

jankatins commented 9 years ago

LGTM.

Same comment as in #25: if you want to start a unittest, I'm fine with anything which can be run by nosetests in the basedir. If you don't have time, I will merge this anyway and start one with my next knitpy code run...

If your colleagues have some requirements they want to see implemented, let me know.

jankatins commented 3 years ago

Project is dead, sorry! Please consider https://github.com/executablebooks/jupyter-book as a replacement.