search

jankatins / knitpy

knitpy: Elegant, flexible and fast dynamic report generation with python
https://github.com/jankatins/knitpy
Other
368 stars 29 forks source link

Fix not honoring `include=False` code when `eval=False` #50

Closed eddiejessup closed 7 years ago

eddiejessup commented 7 years ago

Fix not honoring include=False code when eval=False

eval=False adds code to output regardless of the value of include. It seems like include=False implies echo=False and results="hide", so do this.

Also amend help text for include argument, to remove statement that chunk will not be run. This should depend only on the eval argument, according to the example document.

jankatins commented 7 years ago

LGTM, will merge!

Thank you for your contribution!