jankkm / invidioucious

Invidious redirector for Firefox with options
The Unlicense
1 stars 0 forks source link

"Cookie" option interferes with video site settings #4

Closed eridanired123 closed 5 years ago

eridanired123 commented 5 years ago

Selecting said option on the setting pane, impede loading correctly the own settings of the video site, making effectively impossible to load basic features like signing in or interface language.

jankkm commented 5 years ago

Please check if disabling Proxy mode makes it work again and also please give me an example of a page that breaks.

jankkm commented 5 years ago

Oh I think I misunderstood before. Is this issue about logging into the invidious instance? That makes sense because the cookie header is completely overwritten by the extension. But why would you want to save settings both in the extension and in your account?

eridanired123 commented 5 years ago

No, it is not abut logging to an invidious instance (although you can't do it if you use invidiouscious), it is about being unable to fully use an invidious site when the extension is enabled and the "Cookie" option checked (works well if unchecked).

Steps to reproduce:

Now:

Language isn't the only problem, any other setting is not used if you use the cookie and there is no way to manually configure these settings anywhere making invidioucious not truly usable on many scenarios.

This is of course because the cookie settings seem to be hardcoded, so I see three ways to approach this problem:

  1. Make the cookie manually configurable
  2. Use the settings from the invidio instance (preferable)
  3. Clearly explain in the setting pane what "cookie" option will do, so people don't get confused.
jankkm commented 5 years ago

In short you cannot use a mix of settings from the extension and from your login. Why would you want that. I could:

Which would help you more?

I will add a few words to the settings page that there is no login possible if the extension sends its cookie information.

eridanired123 commented 5 years ago

Both are great options, personally, I would find more useful the first one, to leave only redirection enabled. But the second one may be better for privacy, therefore other users may find it more valuable.

Whichever one you decide on would be a great improvement!

jankkm commented 5 years ago

I just uploaded a new version: -you can set the language now -cookie mode is explained a little better