janko / rodauth-omniauth

OmniAuth login and registration for Rodauth authentication framework
MIT License
48 stars 3 forks source link

identities association use omniauth_identities_account_id_column as key #11

Closed Dainii closed 1 year ago

Dainii commented 1 year ago

Hello,

Following #10, if I understand the code right, the association should be on the foreign key, not the primary.

In your test it works, because the first user has the id 1 as the identity, but otherwise it's not able to find the record or it loads an identity of another account.

I'm not sure how to write a proper test for this though.

janko commented 1 year ago

You're right, I missed that 🤦🏻‍♂️ Thanks for the fix, I will take care of the tests on merging 👍🏻

janko commented 1 year ago

Released 0.3.3 with this fix 🙂

Dainii commented 1 year ago

Thank you ;)