search

janko / rodauth-rails

Rails integration for Rodauth authentication framework
https://github.com/jeremyevans/rodauth
MIT License
571 stars 40 forks source link

Support newrelic_rpm gem instrumentation #121

Closed janko closed 2 years ago

janko commented 2 years ago

The newrelic_rpm gem expects :controller in instrumentation event payload to point to an actual Rails controller, so it tries calling controller_path on it. I considered putting the Rodauth controller there, but I found it misleading, since it's the Rodauth application processing the request, the Rodauth controller is only doing view rendering. In the end I decided to just define a controller_path method on the Rodauth app.

Closes #119

janko commented 2 years ago

@bjeanes Could I ask you to test this out?

bjeanes commented 2 years ago

Can do on Monday!

janko commented 2 years ago

@bjeanes Did you maybe get a chance to try this out?

bjeanes commented 2 years ago

Apologies, I totally forgot to on Monday. I've kicked off a build and deployment against this branch and will check the logs when it is deployed to check. I have family visiting at the moment so my time is fragmented. I may get back to you in a few hours, but if it takes too long it may be a few days.

bjeanes commented 2 years ago

It looks like our branch deployments have an issue when using git gems. I've pulled in another engineer to take a look while I'm off work. I don't want to merge this to main for staging/prod deploy without closer attention since it skips over quite a few versions of rodauth, rodauth-rails, and some dependent gems.

bjeanes commented 2 years ago

I realised I was actually able to deploy this to our beta environment from a branch. I don't see these exceptions in the logs anymore. I think this likely does the trick, but I'm not sure if there were multiple underlying causes but the common one seems addressed with this 👍🏻