janko / rodauth-rails

Rails integration for Rodauth authentication framework
https://github.com/jeremyevans/rodauth
MIT License
599 stars 40 forks source link

Update README to provide some help for Heroku users #19

Closed SilaSpet closed 3 years ago

SilaSpet commented 3 years ago

The error mentioned in the changes happened to me. Took me a while to find the root cause of the problem since it only happened in production and the error message isn't that helpful. I think the changes in the README are pretty self-explanatory but if you have any questions I'd be happy to answer them.

janko commented 3 years ago

Thank you for the PR. I took it a step further and made rodauth-rails automatically pick up the secret key base from $SECRE_KEY_BASE in https://github.com/janko/rodauth-rails/commit/47059bb1d842064ce2b129a335d324a0f0f72d1c. Could you test whether the current master branch works for you? Afterwards I'll release a new version 😉

SilaSpet commented 3 years ago

I just removed my hmac_secret fix, deployed the current master to staging and added & authenticated via WebAuthn. Works perfectly! 🎉

janko commented 3 years ago

Great to hear! I've just released version 0.7.0 with this fix.

SilaSpet commented 3 years ago

Updated and deployed to production 🚀 Thanks for the quick fix!