search

janko / rodauth-rails

Rails integration for Rodauth authentication framework
https://github.com/jeremyevans/rodauth
MIT License
584 stars 40 forks source link

Should Default Account Status Be 'Unverified'? #27

Closed basabin54 closed 3 years ago

basabin54 commented 3 years ago

Hello! First time issue submitter, so please forgive me if I've done something wrong 😅

I believe the default account status in the base migration generator should be 'unverified' instead of 'verified'.

In Rodauth's default DB config, the default is 1 which maps to 'unverified': http://rodauth.jeremyevans.net/rdoc/files/README_rdoc.html#label-Creating+tables

And in the docs on this gem in the section about moving the account statuses to their own table, it also recommends setting the default to 1 which maps to 'unverified': https://github.com/janko/rodauth-rails#account-statuses

Here's the line where I think the default needs to be changed to 'unverified': https://github.com/janko/rodauth-rails/blob/a901acfe4dd693c167083d08d5b543be85f710a7/lib/generators/rodauth/migration/base.erb#L12

If you'd like me to submit a PR for it I can

janko commented 3 years ago

You're right, it should, good catch 👍

A pull request would be great.

janko commented 3 years ago

Addressed in https://github.com/janko/rodauth-rails/pull/28