search

janko / uppy-s3_multipart

Provides Ruby endpoints for AWS S3 multipart uploads in Uppy
https://uppy.io/docs/aws-s3/
MIT License
65 stars 21 forks source link

CORS Configuration README update #1

Closed FunkyloverOne closed 6 years ago

FunkyloverOne commented 6 years ago

Hey Janko, thanks for this gem and all the shrine related stuff, it's really amazing!

Here's a small thing, your CORS Configuration script is not enogh, as Uppy actually requires not to just allow ETag, but to expose it! Here: https://uppy.io/docs/aws-s3-multipart/#S3-Bucket-Configuration

So we need to have that <ExposeHeader>ETag</ExposeHeader> in the script if possible, or just mention it in README, so back-end devs will not forget about it :)

janko commented 6 years ago

Thanks for reporting, I didn't catch the "expose" <=> "allow" difference in the Uppy docs. For me it still worked with this CORS configuration, but it's better to update the README to what Uppy officially recommends.