Aborting uploads with null key

janko / uppy-s3_multipart

Provides Ruby endpoints for AWS S3 multipart uploads in Uppy

https://uppy.io/docs/aws-s3/

MIT License

65 stars 21 forks source link

Aborting uploads with null key #18

Closed janklimo closed 3 years ago

janklimo commented 3 years ago

As explained in this issue, Uppy will try to abort multipart uploads with key of value null when you abort too fast.

Steps:

Start a bulk upload with several larger files
Cancel immediately

@janko do you think we should handle that in this gem? We see quite a few of these in production so I'd like to contribute a fix.

janko commented 3 years ago

If I understand correctly, this is ultimately a bug in Uppy? I'm not sure how I feel about working around an issue that should be solved elsewhere. Even Uppy's official API backend for multipart S3 uploads has the same issue, right?

jclusso commented 3 years ago

This seems like something that should just return a 404 vs raising an error. Even if it wasn't an issue in Uppy, what if an actual key was passed and in, but it was deleted elsewhere.

janko commented 3 years ago

That sounds reasonable to me. Would you like to submit a pull request?

janko commented 3 years ago

Released 1.1.0 with changes in https://github.com/janko/uppy-s3_multipart/pull/21.