jankohlbach / the-best-theme

The one and only VS Code Theme
24 stars 0 forks source link

Improve contrast for statusBar.debuggingBackground #5

Closed aravindvnair99 closed 3 years ago

aravindvnair99 commented 3 years ago

Original (Before fix for #4)

https://contrast-ratio.com/#%23cccccc-on-%23cc6633

image

The current version as per https://github.com/jankohlbach/the-best-theme/commit/d470a256d1539bbd723963a9021ef8788080f64d

https://contrast-ratio.com/#%23fff-on-%23cc5522

image

My change (This PR)

https://contrast-ratio.com/#%23ffffff-on-%23A33107

image

aravindvnair99 commented 3 years ago

Reference: https://www.w3.org/TR/WCAG20/#visual-audio-contrast-contrast

jankohlbach commented 3 years ago

hey @aravindvnair99 first, thanks for contributing :) do you think it's really necessary to be that dark? 🤔 not sure if I like it that dark, wanted to keep it more like originally

jankohlbach commented 3 years ago

well, I guess it should be 4.5 at least then, I will see if I can make it just a little bit darker then

aravindvnair99 commented 3 years ago

do you think it's really necessary to be that dark? 🤔

@jankohlbach Not really 😅

not sure if I like it that dark, wanted to keep it more like originally

Me neither... Was just trying to improve the contrast a bit more.

well, I guess it should be 4.5 at least then, I will see if I can make it just a little bit darker then

I was trying to make it at least 7. I will also look for alternative colours and update you here.

jankohlbach commented 3 years ago

probably going for this one

image

aravindvnair99 commented 3 years ago

@jankohlbach My updated suggestion:

image