Closed aravindvnair99 closed 3 years ago
hey @aravindvnair99 first, thanks for contributing :) do you think it's really necessary to be that dark? 🤔 not sure if I like it that dark, wanted to keep it more like originally
well, I guess it should be 4.5 at least then, I will see if I can make it just a little bit darker then
do you think it's really necessary to be that dark? 🤔
@jankohlbach Not really 😅
not sure if I like it that dark, wanted to keep it more like originally
Me neither... Was just trying to improve the contrast a bit more.
well, I guess it should be 4.5 at least then, I will see if I can make it just a little bit darker then
I was trying to make it at least 7. I will also look for alternative colours and update you here.
probably going for this one
@jankohlbach My updated suggestion:
Original (Before fix for #4)
https://contrast-ratio.com/#%23cccccc-on-%23cc6633
The current version as per https://github.com/jankohlbach/the-best-theme/commit/d470a256d1539bbd723963a9021ef8788080f64d
https://contrast-ratio.com/#%23fff-on-%23cc5522
My change (This PR)
https://contrast-ratio.com/#%23ffffff-on-%23A33107