search

jankotek / mapdb

MapDB provides concurrent Maps, Sets and Queues backed by disk storage or off-heap-memory. It is a fast and easy to use embedded Java database engine.
https://mapdb.org
Apache License 2.0
4.87k stars 872 forks source link

Move from `net.jpountz.lz4:lz4` to `org.lz4:lz4-java` #992

Closed harpocrates closed 1 year ago

harpocrates commented 3 years ago

The former appears to have migrated to the latter, as per the advisory notice on https://mvnrepository.com/artifact/net.jpountz.lz4/lz4. Another hint: net.jpountz.lz4 hasn't been updated since 2014 while org.lz4 is still seeing recent updates.

s34gull commented 1 year ago

Please consider this PR. org.lz4:lz4-java is now at 1.8.0. I've only recently discovered that newer versions of Apache Kafka actively seek out this old version of lz4, and won't decompress properly, even if newer lz4 libraries are on the classpath.

    ... 3 common frames omitted
Caused by: org.apache.kafka.common.KafkaException: java.lang.RuntimeException: Kafka has detected detected a buggy
lz4-java library (< 1.4.x) on the classpath. If you are using Kafka client libraries, make sure your application does not
accidentally override the version provided by Kafka or include multiple versions of the library on the classpath. The lz4-java
version on the classpath should match the version the Kafka client libraries depend on. Adding -verbose:class to your JVM 
arguments may help understand which lz4-java version is getting loaded.
jankotek commented 1 year ago

Ok, will integrate and release over weekend

LeifW commented 1 year ago

FYI, since this was opened, lz4-java 1.8.0 has been released (on 2021-06-08).

jankotek commented 1 year ago

I will probably make it optional dependency.

s34gull commented 1 year ago

@jankotek any blockers (other than time) for merging this PR?

LeifW commented 4 months ago

This was merged to master, but master isn't incorporated into releases?