search

jankrepl / deepdow

Portfolio optimization with deep learning.
https://deepdow.readthedocs.io
Apache License 2.0
875 stars 136 forks source link

Remove save_best_only #88

Closed jankrepl closed 3 years ago

jankrepl commented 3 years ago

The ModelCheckpointCallback has a parameter save_best_only in the constructor and the logic was never implemented. For now we just remove this parameter.

Closes #85

codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (cadc3e2) into master (f123a82) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1731      1730    -1     
=========================================
- Hits          1731      1730    -1
Impacted Files Coverage Δ
deepdow/callbacks.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f123a82...cadc3e2. Read the comment docs.