search

jankrepl / mildlyoverfitted

Paper implementations from scratch and machine learning tutorials
MIT License
337 stars 125 forks source link

Added date feature to openai_function_calling #21

Closed hrushik98 closed 1 year ago

hrushik98 commented 1 year ago
jankrepl commented 1 year ago

@hrushik98 Thank you for the PR:) That is a pretty cool change:)

I just wonder, does it matter whether the system message comes first or not?

hrushik98 commented 1 year ago

Hey :) I don’t think the order of it really matters. The openai documentation doesn’t explicitly mention anything about the order and as far as I have observed with my projects, I have not found any difference.

On Fri, 7 Jul 2023 at 10:36 PM, Jan @.***> wrote:

@hrushik98 https://github.com/hrushik98 Thank you for the PR:) That is a pretty cool change:)

I just wonder, does it matter whether the system message comes first or not?

— Reply to this email directly, view it on GitHub https://github.com/jankrepl/mildlyoverfitted/pull/21#issuecomment-1625699856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVW3RHFGIQRSXR4PYDUORTDXPA6ZLANCNFSM6AAAAAA2CBJNAQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from Gmail Mobile

jankrepl commented 1 year ago

@hrushik98 Thank you for the contribution:)

hrushik98 commented 1 year ago

You’re welcome ;) Cheers!

On Sat, 8 Jul 2023 at 6:14 PM, Jan @.***> wrote:

@hrushik98 https://github.com/hrushik98 Thank you for the contribution:)

— Reply to this email directly, view it on GitHub https://github.com/jankrepl/mildlyoverfitted/pull/21#issuecomment-1627234685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVW3RHCZUSS36A6P5J3577LXPFI4NANCNFSM6AAAAAA2CBJNAQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from Gmail Mobile