jankrib / ha-xcomfort-bridge

Eaton xComfort integration with Home Assistant
Apache License 2.0
31 stars 13 forks source link

Make Identifier field voluntary and fix the readme #9

Closed jankrib closed 2 years ago

jankrib commented 2 years ago

This field is useful for those who care about unique ids. It should be easy to skip, though. And the way it's described in the readme doesn't make sense.

jankrib commented 2 years ago

Feel free to add to the issue @skela, since it was you that introduced it.

skela commented 2 years ago

Yeah it's just a nickname or reference. Useful for some, I like being able to name my things so 😂

It was meant to be optional sure, I thought it defaulted to use the ip address if missing.

skela commented 2 years ago

Although having the ip as a fallback identifier is pretty awful if I think about it.

Maybe it could default to "XComfort Bridge" unless identifier is supplied?

jankrib commented 2 years ago

"XComfort Bridge" makes sense as a default.

jankrib commented 2 years ago

Fixed this is the last build