search

janmisek / ember-error-handler

Error handling for ambitious web applications
MIT License
4 stars 2 forks source link

Breaks fastboot #3

Open vlascik opened 6 years ago

vlascik commented 6 years ago

I'm trying to use this addon in a fastboot app, but there is a problem: 

ember-error-handler: ErrorHandlerError: Consumer service:ember-error-handler/consumer/wsod-consumer failed
    at get.some.consumer (P:\Project\tmp\broccoli_merge_trees-output_path-2TWjWeAE.tmp\assets\addon-tree-output\ember-error-handler\error-manager.js:90:1)
    at Array.some (<anonymous>)
    at Class.consume (P:\Project\tmp\broccoli_merge_trees-output_path-2TWjWeAE.tmp\assets\addon-tree-output\ember-error-handler\error-manager.js:86:1)
...
Previous: ReferenceError: document is not defined
    at Class.exports.default._emberMetal.Mixin.create._Mixin$create.append (P:\Project\tmp\broccoli_merge_trees-output_path-2TWjWeAE.tmp\assets\ember-views\mixins\view_support.js:136:1)
    at Class.consume (P:\Project\tmp\broccoli_merge_trees-output_path-2TWjWeAE.tmp\assets\addon-tree-output\ember-error-handler\consumer\wsod-consumer.js:62:1)
    at get.some.consumer (P:\Project\tmp\broccoli_merge_trees-output_path-2TWjWeAE.tmp\assets\addon-tree-output\ember-error-handler\error-manager.js:88:1)
    at Array.some (<anonymous>)
    at Class.consume

In ember-error-handler/addon/consumer/wsod-consumer.js line 59, there is a call to component.append();, which calls

_Mixin$create.append = function () {
    return this.appendTo(document.body);
  },

document doesn't exist in fastboot, so this breaks. Maybe there is a different way to add the component, that wouldn't break fastboot?

janmisek commented 6 years ago

Probable cause is here. https://github.com/janmisek/ember-error-handler/blob/master/addon/components/ember-error-handler/wsod-screen-production.js#L8

I am currently busy on project. So I am unable to fix it. But feel free to give me pr.

Thanks for report.