janmojzis / tinyssh

TinySSH is small server (less than 100000 words of code)
Creative Commons Zero v1.0 Universal
1.41k stars 75 forks source link

Tests should be optional #2

Open Civil opened 9 years ago

Civil commented 9 years ago

Hi,

I'd like to make a package of tinyssh in Gentoo, but currently it's required a lot of patching to build system.

Tests should be optional - otherwise it'll break cross compilation. Also portage runs under unprivileged user, so one test will always fail. Also because of that it's now impossible to crosscompile tinyssh.

grazzolini commented 8 years ago

I don't know it this is related to the same issue you are facing, @Civil. But I have a similar issue that appeared on 20160301 that is affecting the build of tinyssh in some cases. I'm one of the maintainer of the tinyssh AUR package for Archlinux, and the build process fails on one test:

--- tinysshd.exp 2016-02-26 05:10:22.000000000 -0300 +++ tinysshd.out 2016-03-18 10:48:40.663333332 -0300 @@ -477,7 +477,7 @@

--- tinysshd 'logs kex problem' when client closed the connection

-unable to receive kex-message (connection reset) +unable to send kex-message (broken pipe)

--- tinysshd 'logs kex problem' when client disconnected the connection

On previous versions I didn't had this issue. Also, it seems not to affect every system, but we had reports of some people not being able to build the package. And I reproduced this error using a qemu-kvm virtual machine.

grazzolini commented 8 years ago

And I just saw now that issue #13 fixed this problem. Sorry for the noise.

Civil commented 8 years ago

Well, my problems are related to the fact that gentoo builds packages inside a sandbox and some features are not allowed there, but tests are using them, so they obviously fails.

Currently there is no way to remove tests without hacking into build system which I don't actually want to do (cause it's too weird). So I'll wait until author will switch to something saner than bash scripts as a build system (e.x. autotools, cmake, etc).

lilydjwg commented 8 years ago

I have problems with the tests as well as I'm cross-compiling. tinyssh is well suited for tiny embedded systems, except that it's so unpleasant to cross-compile.

janmojzis commented 8 years ago

Hello, can You prepaire separate Makefile, make* script or something like that to allow cross-compiling?

janmojzis commented 8 years ago

I tried to add support for cross-compilation in the branch cc, script make-tinysshcc.sh

Can You please try it?

Thanks Jan

lilydjwg commented 8 years ago

@janmojzis make-tinysshcc.sh works fine for me :+1: