soc-pe-bot
commented
4 months ago Team's Response
Thank you for pointing this out. It is a useful enhancement for fast typers. Nonetheless, all the prefixes were implemented to take in lowercase letters only for consistency among functions, and the app in its current form works as such.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: As your group has pointed out, making hp prefix case insensitive is a " useful enhancement for fast typers". As this tp project is one that explicitly caters to fast typists and that should be optimised for fast typists, I do not believe that this is an enhancement that is beyond the scope of this project and can be considered as not in scope. It is a fundamental requirement that the you include enhancements to make the lives of fast typists easier when they use your app.
Furthermore, it is also mentioned in the tp bug guidelines that an example of a bug is "making keywords case-sensitive when there is no need for it". This can be seen below. There is no reason for your prefixes, which is a keyword that is used frequently, to be case sensitive as you do not have another prefix with exactly the same letters. Furthermore, the fix for this requires minimal effort as you simply have to include a .lower() to your input string. With this simple fix, you allow your users the flexibility to enter their commands even if they have typos that accidentally capitalise your prefix.
Especially as you are trying to cater to fast typists, such typos can occur frequently as they are typing very quickly. Thus this case-insensitivity of hp prefix is a valid aspect of your command that you have forgotten to consider. Thus, as it is not optimised enough for fast typists, it is a feature flaw.
As per UG, i have used the create command. However, i have capitalised the prefix HP Input : ic/S0123456C HP/87654321 a/311, Clementi Ave 2, #02-25 dob/1990-01-01 s/F st/PENDING e/janed@example.com bt/A+ n/Cane Doe Output : invalid command format error
I expected the command to be accepted as prefixes should be case-insensitive. However, this comomand was blcoked. This behaviour is problematic because it is not optimised for fast typist that could easilt make a mistkae.