soc-se-bot
commented
4 months ago Team's Response
Thank you for your suggestion. As currently we are assuming most patients visiting Singapore GP clinics will have Singaporean phone numbers, the area code is not needed. However, the app still functions as intended and takes in 8 digits as a phone number. This is still a useful suggestion for future iteration though, where the app scales up to be used by overseas clinics.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: As shown in the the tp guideline below, overzealous blocking of phone numbers is a feature flaw.
By only accepting 8 digits, it is problematic in several ways. Firstly, doctors cannot save the contacts of international patients such as those from vietnam or thailand with 9 digits in their phone numbers. They also cannot save their area codes. This would be problematic for the doctors as they would have to keep these contacts in a seperate place, making using your app much less convenient. Another issue, by only allowing 8 numbers, this would mean the doctors are unable to save multiple contacts of users(in the case patients have more than one phone, or need to save another contact as an emergency contact). Also show in the guideline below, blocking the input of multiple phone numbers might not add any value but allowing it does. Following the guideline, this is immediately a feature flaw. Allowing for such cases will also not hinder the operation of your software in any way.
To also directly address your rebuttal, your assumption of "most patients visiting Singapore GP clinics will have Singaporean phone numbers" is not stated in your user guide. It is also not valid as singapore is a melting pot of cultures that welcomes foreigners. These foreigners fall sick too and need to go to the doctor. As GPs in Singapore provide primary care for sick people, it is quite normal for foreign individuals to seek help at GPs.
input: create ic/T0123456G hp/6587654321 a/311, Clementi Ave 2, #02-25 dob/1990-01-01 s/F st/PENDING e/janed@example.com bt/A+ n/Jane Doe output : error message saying that the phone number is an invalid format, blocking my command
I expected that the number should be accepted, given that it is logical to put area codes in phone numbers.
However, phone numbers with more than 8 numbers are blocked. This is problematic as it conveniences users who may want to say international numbers that are more than 8 numbers.