jannikbuschke / gatsby-antd-docs

A gatsby starter for a technical documentation website
https://www.jannikbuschke.de/gatsby-antd-docs/
MIT License
68 stars 21 forks source link

Upgrade to Gatsby v4 Stable release #33

Closed rmatambo8 closed 2 years ago

rmatambo8 commented 3 years ago

Hi! In case you didn’t know, Gatsby is planning its next major version for Q4 of this year! In preparation, the Gatsby team is reaching out to maintainers for our most popular Starters to help make the upgrade to Gatsby 4 as smooth as possible.

This PR updates your Gatsby Starter to the alpha version of this next release, as well as some related plugins. It’s just in draft form for now, since the 4.0.0 version of Gatsby isn’t quite ready for release yet. We’re mainly testing updating Gatsby and the other official plugins to ensure that the Starter builds without errors.

You may see some warnings from packages that list gatsby: ^3.0.0 as a peer dependency. Don’t worry, we’ll come back and fix those before we take this PR out of draft mode when it’s ready to be merged.

Once version 4.0.0 is ready, we'll come back to update the dependencies and convert this draft to a PR for review. Until then, no action is required on your end. If you have any questions / concerns, let us know in the comments.

Thanks again for all your work as a Gatsby maintainer. We’re so grateful to have you as part of our community. 💜

For more information on what’s coming with Gatsby v4, check out the [GitHub Discussion](https://github.com/gatsbyjs/gatsby/discussions/32860](https://github.com/gatsbyjs/gatsby/discussions/32860).

Changes:

rmatambo8 commented 3 years ago

Note: gatsby 4 is now in beta so i updated this to beta.

there were a few other things to note:

the use of serve was somewhat problematic locally with the path prefixes so i also updated the path prefix to point to the same path both in production and development at the start. The documentation makes it pretty clear how to use it so i think that would be a good change. Also, since you only use the path prefix property when you build, it may make sense not to have the ternary at all in gatsby-config.

I hope this helps!

jannikbuschke commented 2 years ago

thank you for your support with upgrading.

pls let me now when g4 is ready

rmatambo8 commented 2 years ago

Hi! Good news! Gatsby is almost ready for the stable release of version 4.0.0.

We reached out to you when we were updating to alpha and when we successfully launched a beta version of your site which you can find at this link.

We are planning on having a major launch day this month and we would like to merge all of these changes, we would like to feature your starter from day 1 of Gatsby 4 GA. Would you be up for merging on the launch day?

As always, thanks again for being awesome as a Gatsby maintainer. We’re so grateful to have you as part of our community. 💜

In the mean time, feel free to jump into the discussion on quality starters for Gatsby v4 in the GitHub Discussion

rmatambo8 commented 2 years ago

Gatsby 4 is now GA! I've updated the gatsby dependencies to 4.0.0. Take a look, and if everything looks good, feel free to merge!

jannikbuschke commented 2 years ago

thank you @rmatambo8 🙏

rmatambo8 commented 2 years ago

any time, I look forward to seeing what kind of starters you come up with next 😄