search

janniklaval / phratch

Phratch is based on Scratch with more features
Other
22 stars 10 forks source link

Import sources from smalltalkhub #248

Closed grype closed 5 years ago

grype commented 5 years ago

I tried loading Phratch into Pharo 7, and ran into some problems, mostly due to obsolete code. Then I noticed your repo on GH didn't have any actual source code. So, I looked into migrating all the existing sources to GH as well as fixing the few issues I ran into on Pharo 7. This PR is the result of that effort.

All of the commits found on http://smalltalkhub.com/#!/~JLaval/Phratch were migrated to GH. d78c247 records the few differences that resulted in the image after first loading the sources from smalltalkhub and then merging the image with all the migrated GH commits. Please take a look...

e2b757e adds BaselineOfPhratch, so now you can load the code with:

Metacello new
  baseline: 'Phratch';
  repository: 'github://grype/phratch:import';
  load.

Commits that follow e2b757e address all the issues I ran into while trying to load Phratch and all of the add-ons.

About the add-ons - It looks like they were getting referenced from configurations stored on a separate repo on http://smalltalkhub.com/#!/~JLaval/PhratchMetaRepo. And both - Phratch's loading mechanism and the add-on configurations, are referencing the smalltalkhub repo. So, I ended up creating a separate repo on GH to mimic the setup - https://github.com/grype/PhratchMetaRepo and migrating all of the configs there. Of course now they have become BaselineOf's. I kept all of the original ConfigurationOf classes in both repos. I'd also gladly transfer PhratchMetaRepo to you if you'd like.

janniklaval commented 5 years ago

Hi Pavel,

I tried few months ago, but there was an error in the importer.

For the MetaRepo, I propose to create one on my account.

What do you think ?

De : Pavel notifications@github.com Envoyé : vendredi 15 mars 2019 04:55 À : janniklaval/phratch phratch@noreply.github.com Cc : Subscribed subscribed@noreply.github.com Objet : [janniklaval/phratch] Import sources from smalltalkhub (#248)

I tried loading Phratch into Pharo 7, and ran into some problems, mostly due to obsolete code. Then I noticed your repo on GH didn't have any actual source code. So, I looked into migrating all the existing sources to GH as well as fixing the few issues I ran into on Pharo 7. This PR is the result of that effort.

All of the commits found on http://smalltalkhub.com/#!/~JLaval/Phratch were migrated to GH. https://github.com/janniklaval/phratch/commit/d78c24708a201fd9fd61069318137fa6964d8775 d78c247 records the few differences that resulted in the image after first loading the sources from smalltalkhub and then merging the image with all the migrated GH commits. Please take a look...

https://github.com/janniklaval/phratch/commit/e2b757e2d4ab16caf5951b1605ab2435f463a43c e2b757e adds BaselineOfPhratch, so now you can load the code with:

Metacello new

baseline: 'Phratch';

repository: 'github://grype/phratch:import';

load.

Commits that follow https://github.com/janniklaval/phratch/commit/e2b757e2d4ab16caf5951b1605ab2435f463a43c e2b757e address all the issues I ran into while trying to load Phratch and all of the add-ons.

About the add-ons - It looks like they were getting referenced from configurations stored on a separate repo on http://smalltalkhub.com/#!/~JLaval/PhratchMetaRepo. And both - Phratch's loading mechanism and the add-on configurations, are referencing the smalltalkhub repo. So, I ended up creating a separate repo on GH to mimic the setup - https://github.com/grype/PhratchMetaRepo and migrating all of the configs there. Of course now they have become BaselineOf's. I kept all of the original ConfigurationOf classes in both repos. I'd also gladly transfer PhratchMetaRepo to you if you'd like.

You can view, comment on, or merge this pull request online at:

https://github.com/janniklaval/phratch/pull/248

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/janniklaval/phratch/pull/248 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAZWGubx7XbYXpKkQSpvqIGxtxswvJSIks5vWxmlgaJpZM4b1qOX . https://github.com/notifications/beacon/AAZWGk6TCopglA2JvK7UkzjlMXOmmiBcks5vWxmlgaJpZM4b1qOX.gif

grype commented 5 years ago

Jannik,

That would be preferable! I'll transfer the MetaRepo to you. I migrated all of the config classes from smalltalkhub, added Baselines and just updated relevant baselines to point back to janniklaval/phratch. Mind you not all of the baselines are loadable into Pharo 7, though most are.

Also, don't forget to update the repository reference in MetaRepoSearcher>>loadProject:, which lives in janniklaval/phratch.

grype commented 5 years ago

Jannik, there's also a few other things that didn't make it into the import branch as I wanted to keep that one as close to the smalltalkhub codebase as possible. Of those things - saving/opening projects is the biggest - those operations lead to crashes on Pharo7. I got most of the issues sorted out, but not all just yet. The rest of the changes are mostly around UI, and specifically as they pertain to the dark theme. See grype/phratch:fixups