search

jannikmi / timezonefinder

python package for finding the timezone of any point on earth (coordinates) offline
https://timezonefinder.michelfe.it/
MIT License
461 stars 50 forks source link

Can't install `timezonefinder` with numpy 2.0 #234

Closed Gui-FernandesBR closed 4 months ago

Gui-FernandesBR commented 4 months ago

Hello,

numpy 2.0.0 was officially released today (https://pypi.org/project/numpy/) However, the pyproject.toml file states numpy<2.0 as a dependency for timezonefinder. I have successfully executed all the tests from the tests folder after updating numpy to 2.0. It seems like this project doesn't really requires numpy <2.

Can we flexibilize the rules in the pyproject.toml file so timezonefinder can be installed with numpy 2.0?

There's a migration guide for numpy 2.0. The Python API changes are minimum:

Gui-FernandesBR commented 4 months ago

@jannikmi if you need help I could open up a PR solving this issue.

As far as I understand, no modifications to the code source would be needed.

jannikmi commented 4 months ago

Thanks for bringing this up.

jannikmi commented 4 months ago

I am on it.