search

janniks / vue-notion

A fast Vue renderer for Notion pages
https://vue-notion.now.sh
Other
883 stars 65 forks source link

Fix callouts with blocks as content #139

Closed brachkow closed 2 months ago

brachkow commented 1 year ago

This package has issue with callouts that use blocks as content instead of text. These callouts render empty.

I mentioned this issue here — https://github.com/janniks/vue-notion/issues/133

As issue is missing in vue3-notion, I investigated how @zernonia fixed that and added his fix.

Important: I just copied code from my fork, without any tests on your fork — so I think you need to test it before merging.

Also with my setup (it has a lot of stuff removed) I got into tricky circular reference bug. Fixed it here https://github.com/tough-dev-school/vue-notion/commit/47e13cb74efe7a9a4dad1aaa55247ec550ee081d. Add this fix if you need it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-notion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 6:40pm
janniks commented 2 months ago

Thanks for this -- fixed now slightly differently in https://github.com/janniks/vue-notion/pull/146