Props pageLinkOptions, mapPageUrl doesn't seem to work properly

jedihugo commented 3 years ago

Version tested: `1.1.3`

Issue: `pageLinkOption` and `mapPageUrl` prop doesn't seem to work

pageLinkOption: doesn't change the component to NuxtLink (per inspection still <a href target=_blank />)

mapPageUrl: doesn't add /post to path before pageId

data() {
return {
pageLinkOptions: { component: "NuxtLink", href: "to" },
};
},
methods: {
mapPageUrl(pageId = "") {
pageId = pageId.replace(/-/g, "");
return `/post/${pageId}`;
}
}

How to reproduce:

I tested on the nuxt example: https://github.com/janniks/vue-notion/tree/main/example/pages/_slug.vue, which already uses pageLinkOption. I added methods mapPageUrl, and call it in the props:
```
<template>
<NotionRenderer
  :blockMap="blockMap"
  :pageLinkOptions="pageLinkOptions"
  :mapPageUrl="mapPageUrl"
  fullPage
  prism
/>
</template>
```
Also tried on my test pageBlocks that has links and urls: 5c9c85aafc584ba18cdae7eb9e13a27c
It doesn't change component to NuxtLink to, still <a href target=_blank />
It also doesn't add subpath /post

janniks commented 3 years ago

Yes, you are right. I found the bugs to fix this. Will release soon

janniks commented 3 years ago

Thanks for the detailed error report. The pageId and info really helped!

I believe this is now fixed in 1.2.1 — Please check to see if everything works as expected... ☺️

janniks commented 3 years ago

Your example works here for this codesandbox

jedihugo commented 3 years ago

This is working now as expected. Thank you!

janniks / vue-notion