search

jannis-baum / fzf-dotfiles

Fast and consistent file management in Zsh and Vim with fzf
3 stars 0 forks source link

Kitty icat doesn't properly capture fzf dimensions #1

Closed prurph closed 11 months ago

prurph commented 11 months ago

This setup is really cool!

Perhaps I somehow have different zsh expansion settings, but as written the FZFDF_IMG command expands the FZF_PREVIEW_ variables when the script is sourced and they do not exist, as opposed to at runtime when fzf is invoked. Consequently image previews error with an atoi error inside kitty because the command is effectively receiving --place=x@0x0 {}.

I was able to fix this by escaping the dollar signs on this line as: \${FZF_PREVIEW_COLUMNS}x\${FZF_PREVIEW_LINES}@0x0.

jannis-baum commented 11 months ago

Hey! I just saw that the problem you mentioned is actually a problem on my setup as well; I must have rushed the testing. I added your fix in the latest commit and set you as a co-author, thank you!

I'm happy you like the setup! If you have any feedback on how usable this is I'd be happy to hear about it since I'm trying to make my dotfiles as modular as possible but so far I'm probably the only person using them🙈

I also have some other repos in case you are interested in them; particularly the git-related dotfiles with lots of fzf-functions and si-vim if you use Vim might be interesting for you :)