jannispinter / jaws

JAWS - Just another wifi scanner
GNU General Public License v3.0
42 stars 6 forks source link

[ON/OFF] switch in-app (awaiting for user feedback) #4

Open GreenLunar opened 9 years ago

GreenLunar commented 9 years ago

User is forced to resort to built-in wifi scanner to turn off wifi.

EDIT: Battery saving mode nullifies the above statement.

jannispinter commented 9 years ago

I'm implementing this a I'm writing. This feature will land in version 0.3 which will be released tomorrow. Thanks! :)

GreenLunar commented 9 years ago

Awesome!

jannispinter commented 9 years ago

Hi! I just published version 0.3.

I've added a battery saving option in the preferences. This will switch off WiFi when the app moves into background. The app will automatically switch WiFi on again, when it comes to foreground.

Does this suit your needs? I'm planing to add a special button to turn off scanning (and therefore WiFi as well, when the option mentioned above is ticked in the preferences) to the toolbar in version 0.4.

Thanks for your support! :-)

GreenLunar commented 9 years ago

Actually, a special button to do this task, manually, is what I had in mind. Shall we reopen this issue, then?

notfoss commented 9 years ago

Hi, I feel that it should only switch off wifi, if it started it in the first place. If wifi was already running before starting this app, then the "Safe battery" option shouldn't turn it off.

jannispinter commented 9 years ago

Thanks for the suggestion, that obviously makes sense. I will implement this in version 0.4.

GreenLunar commented 9 years ago

In the past couple of weeks, I have used JAWS, exclusively, for Wi-Fi.

I think that the current way, not having [ON/OFF] switch in-app is good.

Perhaps you should just add a warning message that Wi-Fi is about to be turned off when clicking on back button or when selecting battery saving mode; if such dialog be added, add a Do not show this message again check-box.

In case CyanogenMod project be interested in including JAWS as a default Wi-Fi scanner only if it would have an [ON/OFF] switch, then it would be reasonable to add it, but, then again, maybe JAWS should have such switch anyway.

GreenLunar commented 9 years ago

Please reopen if you think that users will not be exposed to this issue when is closed.