search

janoliver / pOT-Droid

an Android app to browse the mods.de forums
https://github.com/janoliver/pOT-Droid
GNU General Public License v2.0
32 stars 5 forks source link

YouTube-API non-free? #281

Closed ghost closed 8 years ago

ghost commented 8 years ago

You reference compile files('libs/YouTubeAndroidPlayerApi.jar'), but it is git-ignored. This is most likely the proprietary API-Jar, so could you provide a gradle build flavor that does not depend on it?

janoliver commented 8 years ago

Hi, it is free so I added it to the repo including a custom license. See https://github.com/janoliver/pOT-Droid/tree/master/libs .

ghost commented 8 years ago

I meant free as in freedom, not gratis. So it's proprietary, no source available. Sigh. Any changes providing a pure-floss build with functionality removed?

janoliver commented 8 years ago

Alright, sorry for the misunderstanding. I assume this is for the projects's FDroid build?

I'll figure something out until the 5.0 release. Note, that the current release listed on Github is a pre-release only.

janoliver commented 8 years ago

I removed the feature and library completely in b24f0c5d9b72ef5348021f90f6e55718e4369e5d.

ghost commented 8 years ago

Yup, builds again, thanks for the quick response!