This PR fixes the mission lifetime constraint functionality in the case where
the waveform was being truncated with the max_frequency parameter (i.e. for BWD).
Unfortunately, my previous mistake meant that little to no low-frequency truncation was taking place anymore, so the correctly-computed horizon is quite a bit smaller than the previous plot suggested... :disappointed:
This was in commit d17ac96dba, after which I added a bunch more tests and documentation.
Now I'm getting sensible results for BWD, cropping these (0.6+0.6Msun) at 0.05Hz, 0.1Hz, and their merger frequency of 0.14Hz:
Even the lowest of these is an order of magnitude higher than the highest observed BWD frequencies, unfortunately. I'd say that these are not optimistic, since we would indeed be able to observe such sources for the full mission duration.
This PR fixes the mission lifetime constraint functionality in the case where the waveform was being truncated with the
max_frequencyparameter (i.e. for BWD). Unfortunately, my previous mistake meant that little to no low-frequency truncation was taking place anymore, so the correctly-computed horizon is quite a bit smaller than the previous plot suggested... :disappointed:This was in commit d17ac96dba, after which I added a bunch more tests and documentation. Now I'm getting sensible results for BWD, cropping these (0.6+0.6Msun) at 0.05Hz, 0.1Hz, and their merger frequency of 0.14Hz:
Even the lowest of these is an order of magnitude higher than the highest observed BWD frequencies, unfortunately. I'd say that these are not optimistic, since we would indeed be able to observe such sources for the full mission duration.