Detector frame masses - Githubissues

janosch314 / GWFish

Simulation of detector networks with Fisher-matrix PE

33 stars 20 forks source link

Detector frame masses #82

Closed u-dupletsa closed 6 months ago

u-dupletsa commented 6 months ago

added possibility to input different masses combinations: [mass_1, mass_2], [mass_1_source, mass_2_source], [chirp_mass, mass_ratio] and [chirp_mass_source, mass_ratio]
added possibility to choose numeric format of output file
removed redshift from default fisher_parameters
changed tests and documentation according to changes above

jacopok commented 6 months ago

The changes look good to me! I can approve as is, but maybe one extra nice easy thing could be to have a new test for the equivalence of the different ways to parametrize the mass (for example, the SNR computed stays the same).