Open u-dupletsa opened 3 months ago
Hi, some comments:
minimax_tilting_sampler.py
should be made into an actual test, I think, alsonp.random.seed(10)
for reproducibility on line 432, and nothing else:twinx
, so normalization is lost - the distributions should be correctly normalized, either multiplying the PDF by the number of samples, or by using the density=True
kwarg for the histogram
priors module (tuturial coming soon)