search

janosch314 / GWFish

Simulation of detector networks with Fisher-matrix PE
33 stars 19 forks source link

Added Time/Frequency Series SNR functionality #93

Open LudoDe opened 4 weeks ago

LudoDe commented 4 weeks ago

Added a few functions to the utilities module to calculate the SNR of a Frequency series, and to transform a time series to a Frequency series. Added a tutorial to quickly illustrate this in the form of a Notebook.

jacopok commented 4 weeks ago

Looks good! The only thing I would say is that there appears to be some duplication between the function get_SNR_components and the already existing get_snr; they are slightly different but it would be nice to have a single function to do everything (since it's the same task, conceptually).

LudoDe commented 3 weeks ago

I modified get_snr to have a variable / flag for series, and when it is present it just does what get_SNR_components used to do, it is a bit ugly in code but (so far) seems to have the same functionality