janosh / pymatviz

A toolkit for visualizations in materials informatics.
https://janosh.github.io/pymatviz
MIT License
176 stars 16 forks source link

Delete `correlation.py` module #229

Closed janosh closed 1 month ago

janosh commented 1 month ago

Arguably plotting Marchenko–Pastur distros is too specialized and narrow-purpose to remain in the package

DanielYang59 commented 1 month ago

Hi @janosh I appreciate all your work, but can we perhaps follow the best practice and at least emit a deprecation warning for some period before deletion? Even though it’s quite specialized, it might still be in use by someone?

janosh commented 1 month ago

we could but i'm close to certain nobody ever used this function except me. i only used it in one project couple years ago and i never needed it again after that. that said, i'm open to a deprecation period.

DanielYang59 commented 1 month ago

I would trust your judgement here until someone complains (hopefully not) :)