janoside / btc-rpc-explorer

Database-free, self-hosted Bitcoin explorer, via RPC to Bitcoin Core.
https://bitcoinexplorer.org
MIT License
1.52k stars 1.13k forks source link

I just activated taproot on my node and I see this on softforks #364

Closed vmalarcon closed 2 years ago

vmalarcon commented 3 years ago

Describe the bug

I updated to taproot on my node (core v.0.21.1) and now the soft forks section shows an unparsed json instead of the other soft forks.

Environment (please complete the following information):

Configuration file content

---- /home/bitcoin/.bitcoin/bitcoin.conf ------

# bitcoind configuration
# mainnet/testnet
testnet=0
# Bitcoind options
server=1
daemon=1
txindex=1
disablewallet=0
peerbloomfilters=1
# Connection settings
...
main.rpcport=8332
rpcallowip=127.0.0.1
main.rpcbind=127.0.0.1:8332
zmqpubrawblock=tcp://127.0.0.1:28332
zmqpubrawtx=tcp://127.0.0.1:28333
# Raspberry Pi optimizations
dbcache=512
maxorphantx=10
maxmempool=300
maxconnections=40
maxuploadtarget=5000
datadir=/mnt/hdd/bitcoin
onlynet=onion
proxy=127.0.0.1:9050
main.bind=127.0.0.1
test.bind=127.0.0.1
dnsseed=0
dns=0
main.addnode=ira7kqcbff52wofoong2dieh2xlvmw4e7ya3znsqn7wivn6armetvrqd.onion
main.addnode=xlpi353v7ia5b73msynr7tmddgxoco7n2r2bljt5txpv6bpzzphkreyd.onion
main.addnode=ccjrb6va3j6re4lg2lerlt6wyvlb4tod7qbe7rwiouuapb7etvterxyd.onion
main.addnode=s7m4mnd6bokujhywsocxibispktruormushdroeaeqeb3imvztfs3vid.onion
main.addnode=ldvhlpsrvspquqnl3gutz7grfu5lb3m2dgnezpl3tlkxgpoiw2g5mzid.onion
main.addnode=gliovxxzyy2rkwaoz25khf6oa64c3csqzjn3t6dodsjuf34w6a6ktsyd.onion
test.rpcport=18332
test.rpcbind=127.0.0.1:18332
blockfilterindex=0
main.wallet=wallet.dat

-------- /home/btcrpcexplorer/.config/btc-rpc-explorer.env ------

# Host/Port to bind to
# Defaults: shown
BTCEXP_HOST=0.0.0.0
BTCEXP_PORT=3020
# Bitcoin RPC Credentials (URI -OR- HOST/PORT/USER/PASS)
# Defaults:
#   - [host/port]: 127.0.0.1:8332
#   - [username/password]: none
#   - cookie: '~/.bitcoin/.cookie'
#   - timeout: 5000 (ms)
BTCEXP_BITCOIND_HOST=127.0.0.1
BTCEXP_BITCOIND_PORT=8332
....
#BTCEXP_BITCOIND_COOKIE=/path/to/bitcoind/.cookie
BTCEXP_BITCOIND_RPC_TIMEOUT=10000
# Password protection for site via basic auth (enter any username, only the password is checked)
# Default: none
BTCEXP_BASIC_AUTH_PASSWORD=raspiblB
# Select optional "address API" to display address tx lists and balances
# Options: electrumx, blockchain.com, blockchair.com, blockcypher.com
# If electrumx set, the BTCEXP_ELECTRUMX_SERVERS variable must also be
# set.
# Default: none
BTCEXP_ADDRESS_API=electrumx
BTCEXP_ELECTRUMX_SERVERS=tcp://127.0.0.1:50001

Screenshot from 2021-08-28 09-48-33


To Reproduce

Steps to reproduce the behavior:

  1. Update node to bitcoin core 0.21.1 (taproot)
  2. Open bitcoin explorer with TOR: http://xxxx.onion/node-details
  3. The soft forks section shows:
    taproot
    bip9 - {"status":"locked_in","start_time":1619222400,"timeout":1628640000,"since":687456,"min_activation_height":709632}

    Instead of properly formatted like other soft forks

  4. The JSON output shows the difference:
    {
    "chain": "main",
    "blocks": 697975,
    "headers": 697975,
    "bestblockhash": "00000000000000000003192b02ae5f055f55f0b9da1b62edaafb2b768634d5d0",
    "difficulty": "17615033039278.88",
    "mediantime": 1630148224,
    "verificationprogress": 1,
    "initialblockdownload": false,
    "chainwork": "000000000000000000000000000000000000000020edd78ab8908344e1c2ce70",
    "size_on_disk": 409340911171,
    "pruned": false,
    "softforks": {
        "bip34": {
            "type": "buried",
            "active": true,
            "height": 227931
        },
        "bip66": {
            "type": "buried",
            "active": true,
            "height": 363725
        },
        "bip65": {
            "type": "buried",
            "active": true,
            "height": 388381
        },
        "csv": {
            "type": "buried",
            "active": true,
            "height": 419328
        },
        "segwit": {
            "type": "buried",
            "active": true,
            "height": 481824
        },
        "taproot": {
            "type": "bip9",
            "bip9": {
                "status": "locked_in",
                "start_time": 1619222400,
                "timeout": 1628640000,
                "since": 687456,
                "min_activation_height": 709632
            },
            "active": false
        }
    },
    "warnings": ""
    }

    Screenshot from 2021-08-28 09-48-33

janoside commented 2 years ago

This should be fixed in the latest code. Sorry for the delay. https://bitcoinexplorer.org/node-details