janoside / btc-rpc-explorer

Database-free, self-hosted Bitcoin explorer, via RPC to Bitcoin Core.
https://bitcoinexplorer.org
MIT License
1.54k stars 1.16k forks source link

false error: AddressParseError on legacy address #394

Closed jsarenik closed 2 years ago

jsarenik commented 2 years ago

Describe the bug

The non-bech32 (legacy) address actually works well, but it shows a false error: https://ex.signet.bublina.eu.org/address/n1uJsh2dsd8eNUYE8dq9BHRqAANr3j3XRL

This address was generated by Bitcoin Core 22.0 bitcoin-cli -signet getnewaddress "" legacy.

See the same on testnet: https://ex.testnet.bublina.eu.org/address/n1uJsh2dsd8eNUYE8dq9BHRqAANr3j3XRL

Environment (please complete the following information):

See https://ex.testnet.bublina.eu.org/admin/dashboard

Configuration file content

Please include the content from the following files.

onion=127.0.0.1:9050

[main] bind=0.0.0.0

[test] bind=0.0.0.0

[signet] bind=0.0.0.0

 - Your btc-rpc-explorer environment configuration (either `$WORKING_DIR/.env` or `~/.config/btc-rpc-explorer.env`)

export BTCEXP_HOST=127.0.0.1 export BTCEXP_PORT=3003 export BTCEXP_BITCOIND_HOST=127.0.0.1 export BTCEXP_BITCOIND_PORT=38332 export BTCEXP_BITCOIND_USER=user export BTCEXP_BITCOIND_PASS=password export BTCEXP_DEMO=false export BTCEXP_SLOW_DEVICE_MODE=false export BTCEXP_NO_RATES=true export BTCEXP_UI_HOME_PAGE_LATEST_BLOCKS_COUNT=6 export BTCEXP_FILESYSTEM_CACHE_DIR=../../.cache/signet export BTCEXP_ADDRESS_API=electrum export BTCEXP_ELECTRUM_SERVERS=tls://signet-electrumx.wakiyamap.dev:50002 export BTCEXP_UI_THEME=light



**To Reproduce**

Steps to reproduce the behavior:
1. Go to https://testnet.bitcoinexplorer.org/address/n1uJsh2dsd8eNUYE8dq9BHRqAANr3j3XRL
4. See error on top

**Additional context**

[Signet Faucet](https://signetfaucet.bublina.eu.org) sends the test signet coins to all the possible address types. It all works well, just the "error" in btc-rpc-explorer is misleading.
jsarenik commented 2 years ago

Not present anymore. Closing.