janoside / btc-rpc-explorer

Database-free, self-hosted Bitcoin explorer, via RPC to Bitcoin Core.
https://bitcoinexplorer.org
MIT License
1.5k stars 1.11k forks source link

Peers page don't show map from mapbox.com #456

Closed tadeubas closed 1 year ago

tadeubas commented 2 years ago

Describe the bug

Peers page don't show map from api.mapbox.com because an access_token value is missing!

Environment (please complete the following information):

https://bitcoinexplorer.org/peers

Screenshots or Log Output

image

jsarenik commented 2 years ago

This is intentional. Everyone should rather use their own access_token for the mapbox API.

tadeubas commented 2 years ago

Even on bitcoinexplorer.org demo? If so, you can close this issue, thx!

jsarenik commented 2 years ago

@tadeubas I see your point, and even think it should work there because BTCEXP_MAPBOX_APIKEY is listed in Demo site settings.

@janoside Is mapbox supposed to work on bitcoinexplorer.org instance?

janoside commented 1 year ago

@jsarenik Yes, I had previously configured the demo site to enable the peers map and during a server transition I didn't copy over my API key. Thanks all for catching this. It also turned out there was another bug associated with the peers map, which was fixed in commit 6bfc0876f3.

Thanks.