search

janosrusiczki / japr

Jekyll Asset Pipeline Reborn - Powerful asset pipeline for Jekyll that collects, converts and compresses JavaScript and CSS assets.
MIT License
51 stars 9 forks source link

Enable RuboCop #10

Closed geniou closed 10 years ago

geniou commented 10 years ago

RuboCop is a great tool to analyze your ruby code and ensure that future change will not make you code ugly. I have really good experiences, especially if several people work together on a project. With this commits I enabled RuboCop and fixed the offenses, or disabled them for now.

Let me know what you are thinking about this.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.18%) when pulling 6f11e83583096abeccdebc69188aa20685f32947 on geniou:rubocop into 1835137d3ebf2579d663ad56bf338bac580503b8 on kitsched:master.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.29%) when pulling 6f11e83583096abeccdebc69188aa20685f32947 on geniou:rubocop into 1835137d3ebf2579d663ad56bf338bac580503b8 on kitsched:master.

janosrusiczki commented 10 years ago

Thanks. I read about this gem but never tried it, until now. I've been using Hound to inspect the code of one of my private projects but that only reports on changed lines. I guess I'll give RuboCop a try.

Now it's time to build a gem. :smile:

janosrusiczki commented 10 years ago

Published gem version 0.3.1.

janosrusiczki commented 9 years ago

Hey, I tried to build the gem, and there seems to be some issues generated by rubocop.

Could you take a look?

geniou commented 9 years ago

It looks strait forward what need to be changed / configured - following the instructions rubocop has given. Unfortunately I don't have the time to take a look.. sorry.