janosrusiczki / japr

Jekyll Asset Pipeline Reborn - Powerful asset pipeline for Jekyll that collects, converts and compresses JavaScript and CSS assets.
MIT License
51 stars 9 forks source link

Support Jekyll 3.x #20

Closed zoni closed 6 years ago

zoni commented 8 years ago

Jekyll 3.0.0 was released on 2015-10-26 and 3.1.0 has been released two days ago at the time of this writing (making it 2016-01-23) but japr locks itself to Jekyll 2.x at this time.

It would be nice if it could be updated and a new release made to support the latest version of Jekyll. Looking at the changes it does not look like there would be significant API changes to adapt to.

janosrusiczki commented 8 years ago

If you can build a stable gem locally, could you please create a PR?

natecook1000 commented 8 years ago

The gem works fine with the Jekyll and Liquid dependencies both bumped up to ~> 3.0. Is there a better way to write this? I can submit a PR, but would that require JAPR to bump to version 0.4.0?

janosrusiczki commented 8 years ago

I will rebuild it if you submit the PR. Thanks.

On Sun, Mar 6, 2016 at 10:09 AM, Nate Cook notifications@github.com wrote:

The gem works fine with the Jekyll and Liquid dependencies both bumped https://github.com/natecook1000/japr/blob/nc-jekyll-3/japr.gemspec#L26-L27 up to ~> 3.0. Is there a better way to write this? I can submit a PR, but would that require JAPR to bump to version 0.4.0?

— Reply to this email directly or view it on GitHub https://github.com/kitsched/japr/issues/20#issuecomment-192827318.

janosrusiczki commented 6 years ago

Almost two years late, but version 0.4 was just released with updated support for Jekyll 3.5 and Liquid 4.0.