janosrusiczki / japr

Jekyll Asset Pipeline Reborn - Powerful asset pipeline for Jekyll that collects, converts and compresses JavaScript and CSS assets.
MIT License
51 stars 9 forks source link

minor improvements to README / error output #8

Closed pearsonca closed 10 years ago

pearsonca commented 10 years ago

I ran into some bumps making use of JAPR as a non-ruby dev, and thought I'd offer some suggestions to smooth them out.

Basically, I needed to see the exception messages (why did this asset fail to process?) and thought I'd save the next person the time of sorting out using LESS.

One thing that came out of the troubleshooting: I had previously been using a YAML header in the misbehaving file (which the LESS compiler didn't care for). I'd like to go back to doing that, so I'll be opening an issue.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 685f05b38a96511ffc860aeb3ac055915a544413 on pearsonca:master into c409fdc87ba542c7ed8523ea3911da9ccc36d5a4 on kitsched:master.

janosrusiczki commented 10 years ago

:+1:

Thank you! It's looking good to me, some extra verboseness didn't kill anybody. I'll merge it as soon as I get some more feedback in.

@geniou what say you?

geniou commented 10 years ago

Looks good to me, only the commit message "for not-ruby-users of this" is very strange - is should tell what the commit is for (e.g. Add section about LESS support).

janosrusiczki commented 10 years ago

@pearsonca Can you squash your commit messages into what @geniou suggested? Thanks.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling eff0e4a2e0b105f4e9b96a6eb6f91b417ae6ca54 on pearsonca:master into c409fdc87ba542c7ed8523ea3911da9ccc36d5a4 on kitsched:master.

pearsonca commented 10 years ago

Fiddled with the commit messages / headlines. I reworded the one about exceptions (and actually did a find/replace on exceptions this time, instead of eyeballing it), and just eliminated the message for the README modification.

geniou commented 10 years ago

looks good to me.. but for some reasons travis is not happy about it..

janosrusiczki commented 10 years ago

Re-running the Travis build now.

janosrusiczki commented 10 years ago

I'll be building / publishing the gem these days.

janosrusiczki commented 10 years ago

Published gem version 0.3.1.