Closed pearsonca closed 10 years ago
:+1:
Thank you! It's looking good to me, some extra verboseness didn't kill anybody. I'll merge it as soon as I get some more feedback in.
@geniou what say you?
Looks good to me, only the commit message "for not-ruby-users of this" is very strange - is should tell what the commit is for (e.g. Add section about LESS support).
@pearsonca Can you squash your commit messages into what @geniou suggested? Thanks.
Fiddled with the commit messages / headlines. I reworded the one about exceptions (and actually did a find/replace on exceptions this time, instead of eyeballing it), and just eliminated the message for the README modification.
looks good to me.. but for some reasons travis is not happy about it..
Re-running the Travis build now.
I'll be building / publishing the gem these days.
Published gem version 0.3.1.
I ran into some bumps making use of JAPR as a non-ruby dev, and thought I'd offer some suggestions to smooth them out.
Basically, I needed to see the exception messages (why did this asset fail to process?) and thought I'd save the next person the time of sorting out using LESS.
One thing that came out of the troubleshooting: I had previously been using a YAML header in the misbehaving file (which the LESS compiler didn't care for). I'd like to go back to doing that, so I'll be opening an issue.