search

janpaepke / ScrollMagic

The javascript library for magical scroll interactions.
http://ScrollMagic.io
Other
14.9k stars 2.17k forks source link

Inconsistent GSAP version in bower.json #179

Closed krnlde closed 10 years ago

krnlde commented 10 years ago

Hey Jan, You still use "gsap": "~> 1.11.5" in your bower.json but already use gsap 1.13.1 in your js/_dependent/greensock/ folder.

Could you please update your bower.json? Next time I create a pull request for this, promised.

janpaepke commented 10 years ago

Hm well actually it doesn't NEED 1.13.1 just any version higher than 1.11.5. But I guess I will update to "gsap": "~1.14" as soon as it's released (which should be soon). This is due to the fact that in gsap 1.14.0 is used by nice warning I added in ScrollMagic 1.2.0. See here for more: https://github.com/janpaepke/ScrollMagic/issues/145

krnlde commented 10 years ago

I understand. The thing is GSAP < 1.13 doesn't support AMD/commonjs module loading since this is the first release where they introduced this. So in case you load ScrollMagic as an AMD, require.js will fail loading for example TweenLite. In that case ScrollMagic NEEDS 1.13.1 and up.

janpaepke commented 10 years ago

I see... Well as I said GSAP should be updated in the next couple of days. I will update this then.

euforic commented 10 years ago

@janpaepke Any updates on an eta for this? Sorry to badger we are just using this in a production app the at requires the updates.

janpaepke commented 10 years ago

fixed now. :)

krnlde commented 10 years ago

Thanks man, I'll try it right now.