search

janpantel / angular-sails

An angular module for using the sails socket.io api
MIT License
307 stars 56 forks source link

Added callback to modelUpdater. #58

Closed robgrimball closed 9 years ago

robgrimball commented 9 years ago

This is my first ever pull request so apologies in advance for all that might entail.

It would be really nice to be able to have a callback option for the modelUpdater so that if something changes in the model that callback can be fired. While most applications can probably get away without such and just relying on data binding changes, sometimes you want some logic to occur outside that scope. In my particular case, in using UI-Grid, modelUpdater was updating a field in the model which wasn't being tracked by UI-Grid but which was being relied upon to effect a change in CSS class for a cell in the UI-Grid, so when a change occurred, I needed to call a method to force an update to the UI-Grid to account for possible changes in the cell's CSS class. While I didn't actually personally need to know the object itself or the type of change that occurred, I thought those would be good to have for other use cases.

robgrimball commented 9 years ago

Gah, forgot to add callback parameter, closign this.