search

janpaul123 / delayed-scroll-restoration-polyfill

Polyfill that mimics Chrome's scroll restoration behavior.
Other
105 stars 8 forks source link

SSR compatibility #6

Open bradcgarner opened 5 years ago

bradcgarner commented 5 years ago

Only changed if statement on 1st line so that the polyfill is not attempted when server-side-rendering, but still triggers after the file renders in the browser. For compatibility with Next.js or other SSR technologies.

trotzig commented 5 years ago

Thanks! I'm going to need someone at Brigade merge and release this change (I'm no longer part of the organization).

trotzig commented 5 years ago

@SiriusZael, maybe you can take care of merging and releasing this?

bradcgarner commented 5 years ago

Hey, just checking to see if this PR will be merged. I'm hosting a local copy of the repo, since I can't use the node module with Next.js without this PR. Thanks!!

trotzig commented 5 years ago

Let's ping some folks to see if we can get this merged and released! @eleather, @z3usy - any chance we can get someone on the brigade web team to merge and release this?

bradcgarner commented 5 years ago

Thanks for merging! But just checking when this approved change for SSR will be published. I'm currently hosting a copy of this in each repo that uses it, since the published version won't work with SSR.