janpfeifer / gonb

GoNB, a Go Notebook Kernel for Jupyter
https://github.com/janpfeifer/gonb
MIT License
467 stars 32 forks source link

Rename signals_linux.go to signals_posix.go #112

Closed neomantra closed 3 months ago

neomantra commented 3 months ago

Commit 00adde7 added signals support and used the go:build directive to handle different GOOS. However, since the signals_linux.go files uses one of Golang's magic file name OS endings (_linux.go), it is ignored when GOOS=darwin.

To remedy this, I simply renamed the file to signals_posix.go since it includes POSIX signals such as SIGHUP and SIGTERM.

janpfeifer commented 3 months ago

Thanks Evan @neomantra !