search

janpfeifer / gonb

GoNB, a Go Notebook Kernel for Jupyter
https://github.com/janpfeifer/gonb
MIT License
631 stars 35 forks source link

maybe add some icons #84

Closed potoo0 closed 8 months ago

potoo0 commented 9 months ago

jupyterlab(4.0.10) "Running Terminals and Kernels" tab has render bug when no icons for the kernel (issues: https://github.com/jupyterlab/jupyterlab/issues/14962), maybe we can get those from go.dev.

go.dev icon:

kernel spec folder structure:

kernel.json
logo-32x32.png
logo-64x64.png
logo-svg.svg

Resource reference: https://github.com/jupyterlab/jupyterlab/blob/eff7d42d5437a1f7eef6ab88d96406c5eb5ec2c5/packages/running-extension/src/kernels.ts#L232

janpfeifer commented 8 months ago

Thank you for pointing it ou @potoo0 !!

I'll include the logo in a new version tonight :)

janpfeifer commented 8 months ago

Nice, I think it's done, I created the release v0.9.5 and corresponding docker.

It works for me here: in the left pane, under kernels, I see GoNB kernels with its corresponding new logo (the SVG one).

Let me know if you see any other issues.

Again, thanks for the report!

potoo0 commented 8 months ago

Nice, I think it's done, I created the release v0.9.5 and corresponding docker.

It works for me here: in the left pane, under kernels, I see GoNB kernels with its corresponding new logo (the SVG one).

Let me know if you see any other issues.

Again, thanks for the report!

It works.