search

janpio / ionic-epubjs

Ionic 3 app using Epub.js
https://janpio.github.io/ionic-epubjs/
31 stars 20 forks source link

Added useful files to read epub -zipped files #11

Closed deIdris325 closed 6 years ago

deIdris325 commented 6 years ago

ok

deIdris325 commented 6 years ago

the files are from the epubjs lib. I added in the build folder. Now its possible to "open" epub/3 files

2017-07-16 21:58 GMT+02:00 Jan Piotrowski notifications@github.com:

@janpio commented on this pull request.

Where do these files come from? Also just copied over from the epub.js library? Having the files added and features using them implemented would be better, but I think this will work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/janpio/ionic-epubjs/pull/11#pullrequestreview-50218969, or mute the thread https://github.com/notifications/unsubscribe-auth/AUH5qgooFJ3JoV7QqcwZGnOmbqYxs6t0ks5sOmt6gaJpZM4OZA9Q .

janpio commented 6 years ago

Does this really require all these files? Seems a bit much. I think we should really only add the stuff that is needed - this all has to be maintained :/

deIdris325 commented 6 years ago

your r right! I tested it with the following libs, and works! :

janpio commented 6 years ago

Project already includes a /libs/zip.min.js. The current version also opens a .epub file without problems, so I think these changes are not needed.

Feel free to add the additional files again with future pull requests when you already implement functionality using them.