janraasch / hugo-bearblog

🧸 A Hugo theme based on »Bear Blog«. Free, no-nonsense, super-fast blogging. This theme now includes a dark color scheme to support dark mode 🦉 ⬛️!
https://themes.gohugo.io/hugo-bearblog/
MIT License
887 stars 218 forks source link

Possibly changing "blog" to "blog/" in nav.html? #95

Open h0bbl3s opened 3 months ago

h0bbl3s commented 3 months ago

@janraasch I was having difficulty with my site having some very odd linking behavior related to the blog folder. When I generate my site all of the index.html pages have "/blog" for the link instead of "/blog/".

I'm not entirely sure why but this only seems to affect navigation of the site when visited in firefox on my pc. I attempted to tinker with my nginx configuration but to no avail. I changed line 6 in nav.html to have "blog/" and now all of my index.html files generate properly.

Is this a bug and it should be "blog/"? Or is this just a strange edge case affecting my firefox. I have no issues since generating my site with the altered nav.html . I noticed you have previously removed a leading / in that file. If nothing else can you explain to me what could cause a browsers navigation to get thrown off by the missing / ? Thanks for any help.

janraasch commented 2 months ago

Hi @h0bbl3s,

to be quite honest with you 😇: I can't remember why the blog is not part of the .Site.Menus.main like everything else is (see https://github.com/janraasch/hugo-bearblog/blob/master/layouts/partials/nav.html).

Having this hardcoded blog (or blog/ ... either way 😁) just seems wrong doesn't it? I'd be happy for you to come up with a pr that makes blog/_index.md part of Menus.main.

To your question though: I can follow & understand that the link to /blog is always generated without the trailing slash due to the templating as you pointed out, but I didn't understand how this affects navigation on Firefox for you. Could you elaborate on that please 🙏🏻 ?