search

janraasch / tab-ahead

Web Browser Extension that helps you to quickly find open tabs by title and URL.
MIT License
109 stars 19 forks source link

default should be search all windows #238

Closed leao-nardo closed 3 years ago

leao-nardo commented 3 years ago

not current , because in the current im seeing what is open. . so allshould be default , so people dont need to think its not working and only some will look in the options to change that and in the options put to search on incognitos too

janraasch commented 3 years ago

Hi @leao-nardo,

thank you for your contribution 🙏.

I am a little on the fence about this / #239.

I know some people commented on the Chrome Web Store's review page, that they did not know how to search through all windows.

But then I would be worried now, that by changing the implementation we simply turn this problem around 180 degrees, and people will start commenting about how they do not want to search through all windows 🤓.

I'll let it simmer a little bit 😇. The best way to find out might be to simply give it a try, and watch out for review-comments in the days/weeks after the update.

Just to be sure: You are using this on Chrome, right?

Have a good weekend 🍦, Jan

leao-nardo commented 3 years ago

yes im using Chrome. dificult to be a problem because search all includes the current too . and you could put the box and show the options on the extension page on webstore , so that when a person finds the extension they will know what options have and how to change.

i just saw thats already in the page...well i had forgotten , i use it for many years and may have changed long then ago few weeks ago i reinstaled windows and chrome and it reinstall the extensions synced but it stayed in the default config. and i actually only saw the option because i was thinking it was broken/not working and started to look its configs and search others in the webstore.

that 2 other ideias that i have for it : to look in the incognitos tabs too. and when not finding the tab open -to add the option to search in history too.

do i open an issue for each one ?

leao-nardo commented 3 years ago

actually incognito already work , just tested , it was not searching before for being only in current

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.