janrg / MeeusSunMoon

JavaScript module to calculate times for sunrise, solar noon, and sunset, as well as moon phases based on "Astronomical Algorithms" by Jean Meeus
MIT License
31 stars 9 forks source link

Coverage #11

Closed brettz9 closed 4 years ago

brettz9 commented 4 years ago

Howdy!

I needed a small project for the evening, so I went ahead and added coverage to MSM (and I have one for BadiDate ready if this is accepted) to assist in hopefully gradually getting the tests to cover all portions of the code.

I put the main changes in separate commits, and in an order which is meant to start with less substantive changes, so let me know if you want separate PRs (or if you are even amenable to these changes at all).

I switched from QUnit to Mocha as 1) Mocha seems to be the testing framework these days (or Jest, though that is as I understand compatible) 2) It plays nicely with ESM.