search

jans0n / RewritePlusImprovementPatch

Patch for the English version of Rewrite+
25 stars 4 forks source link

Video files corrupted when downloading the patch from the source code #2

Closed Darken-kun closed 2 years ago

Darken-kun commented 2 years ago

I couldn't reproduce the OPs, the ED and the Yoshino video, neither on Rewrite nor directly on the folder. When I checked possibly why, I noticed the files only had a few bytes each. Then I noticed I had to manually download them instead (maybe because the videos are too big) by going here and clicking individually on them.

I wonder if there isn't a way to overcome this, since most people are just going to download the files as .ZIP from the source code and extract them on the Rewrite+ folder, just to later find out they won't reproduce. Perhaps you need to create a release for this patch in order to enable people to download the videos with their full size? I'm not really used to GitHub, so I don't know for sure.

jans0n commented 2 years ago

Thanks for pointing this out.

Darken-kun commented 2 years ago

No problem. Creating releases not only fixes that issue, but is also useful to have multiple versions of the patch avaliable to download. In case this new update Sekai is preparing for Rewrite+ turns out to be incompatible with your patch, you can create a new release compatible with it, and people can choose between the two of them depeding on which version of the game they have installed.